Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(radio, radio-rich, toggle, checkbox): met a jour les tokens de couleur [DS-3471] #760

Merged
merged 9 commits into from
Nov 10, 2023
Merged

🐛 fix(radio, radio-rich, toggle, checkbox): met a jour les tokens de couleur [DS-3471] #760

merged 9 commits into from
Nov 10, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Sep 4, 2023 •
edited
Loading

  • met a jour les tokens en version cochĂ©e et non cochĂ©e des radio, radio-rich, toggle et checkbox :
    • la coche en $background-active-blue-france
    • la border en $border-action-high-blue-france en non cochĂ©
    • la border en $border-active-blue-france en cochĂ©

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas à vérifier labels Sep 4, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Sep 4, 2023
@zellerbaptiste zellerbaptiste self-assigned this Sep 4, 2023
keryanS

This comment was marked as resolved.

Sign in to view

@keryanS

This comment was marked as resolved.

Sign in to view
@zellerbaptiste zellerbaptiste changed the title 🐛 fix(radio): met a jour les tokens de couleur [DS-3471] 🐛 fix(radio, radio-rich, toggle, checkbox): met a jour les tokens de couleur [DS-3471] Sep 5, 2023
keryanS
keryanS requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@keryanS keryanS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autant pour moi la color était nécessaire sur le before pour le "activer/desactiver"
a revert

@keryanS keryanS requested a review from lab9fr September 11, 2023 15:50
lab9fr
lab9fr requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@lab9fr lab9fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sur le radio rich, changer l'ordre des couleurs de maniÚre à ce que la 2e ne soit pas nécéssaire lorsque non checké pour ne pas induire en erreur
grey en premier, coche en second et fond de coche en 3e

@keryanS keryanS merged commit cfa185d into dev-1.11.0 Nov 10, 2023
4 checks passed
@keryanS keryanS deleted the fix/radio-active-color branch November 10, 2023 13:16
This was referenced Jul 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

@keryanS keryanS keryanS approved these changes

Assignees

@zellerbaptiste zellerbaptiste

Labels
correctif Quelque chose ne fonctionne pas maj 1.10.0 PrĂȘt
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zellerbaptiste @keryanS @lab9fr